From: Timm Bäder <mail@baedert.org>
Date: Sun, 2 Jan 2022 08:46:28 +0000 (+0100)
Subject: label: Remove a redundant assignment
X-Git-Tag: archive/raspbian/4.6.5+ds-1+rpi1~1^2~19^2~4^2~107^2~1
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=b4089672780abd40719ae172fdd02eec229be81a;p=gtk4.git

label: Remove a redundant assignment

clang-tidy says:

gtklabel.c:1188:15: warning: Although the value stored to 'mid' is used in the enclosing expression, the value is never actually read from 'mid'
        min = mid = text_width;
              ^     ~~~~~~~~~~

Which seems right since mid will be assigned to at the beginning of the
next loop iteration anyway.
---

diff --git a/gtk/gtklabel.c b/gtk/gtklabel.c
index 10ee98f5a8..5def4168b6 100644
--- a/gtk/gtklabel.c
+++ b/gtk/gtklabel.c
@@ -1186,7 +1186,7 @@ my_pango_layout_get_width_for_height (PangoLayout *layout,
       pango_layout_get_size (layout, &text_width, &text_height);
       text_width = PANGO_PIXELS_CEIL (text_width);
       if (text_width > mid)
-        min = mid = text_width;
+        min = text_width;
       else if (text_height > for_height)
         min = mid + 1;
       else